I'm following a tutorial to make a news app, I'm getting data from newapi, my code is the same as in the tutorial, but after I update the state (this.state.articles), my component doesn't change. I used the setState function, I tried logging the state in the console, the state looked fine after the update, the render method ran, but nothing changed, something may have gone wrong
My code/component
import React, { Component } from 'react' import NewsItem from './NewsItem' export default class News extends Component { articles = [ { "source": { "id": "espn-cric-info", "name": "ESPN Cric Info" }, "author": null, "title": "PCB hands Umar Akmal three-year ban from all cricket | ESPNcricinfo.com", "description": "Penalty after the batsman pleaded guilty to not reporting corrupt approaches | ESPNcricinfo.com", "url": "http://www.espncricinfo.com/story/_/id/29103103/pcb-hands-umar-akmal-three-year-ban-all-cricket", "urlToImage": "https://a4.espncdn.com/combiner/i?img=%2Fi%2Fcricket%2Fcricinfo%2F1099495_800x450.jpg", "publishedAt": "2020-04-27T11:41:47Z", "content": "Umar Akmal's troubled cricket career has hit its biggest roadblock yet, with the PCB handing him a ban from all representative cricket for three years after he pleaded guilty of failing to report det… [+1506 chars]" }, { "source": { "id": "espn-cric-info", "name": "ESPN Cric Info" }, "author": null, "title": "What we learned from watching the 1992 World Cup final in full again | ESPNcricinfo.com", "description": "Wides, lbw calls, swing - plenty of things were different in white-ball cricket back then | ESPNcricinfo.com", "url": "http://www.espncricinfo.com/story/_/id/28970907/learned-watching-1992-world-cup-final-full-again", "urlToImage": "https://a4.espncdn.com/combiner/i?img=%2Fi%2Fcricket%2Fcricinfo%2F1219926_1296x729.jpg", "publishedAt": "2020-03-30T15:26:05Z", "content": "Last week, we at ESPNcricinfo did something we have been thinking of doing for eight years now: pretend-live ball-by-ball commentary for a classic cricket match. We knew the result, yes, but we tried… [+6823 chars]" } ] constructor() { super(); this.state = { articles: this.articles, loading: false } } async componentDidMount() { const URL = "https://newsapi.org/v2/top-headlines?country=us&category=business&apiKey=" let data = await fetch(URL); let parsedData = await data.json() this.setState({ articles: parsedData.articles }) console.log(this.state.articles) } render() { console.log("render") return ( <div> <div className="container"> <h2 className='my-4 mx-4'> NewsMonkey - Top Headlines </h2> <div className="row"> {this.articles.map((elem) => { return <div className="col-md-4" key={elem.url}> <NewsItem title={elem.title?elem.title.slice(42):""} desc={elem.description?elem.description.slice(0, 88): ""} url={elem.url} imgURL={elem.urlToImage} /> </div> })} </div> </div> </div> ) } }
P粉7247375112023-09-12 17:52:54
Hi @Curious, your code is correct
Just need to pay attention when making map
You are using this.articles
, which is a fixed (emulated) list
You need to call map
in this.state.articles
because this is the state you changed in didMount
P粉3114649352023-09-12 16:04:16
this.articles
and this.state.articles
are not the same.
You have a static property this.articles
, which you use in your rendering logic - this.articles.map(...
. Your fetch is updating the state ( normal operation).
Update your rendering logic to read the data from this.state.articles
and then it should work.