Role-based WordPress redirection using login_url hook

Question

I'm trying to use login_url It works for users who are not logged in. But it doesn't work for logged in users (it redirects them to the /access-denied/ page, which is weird) and I don't really know why.

global $current_user;
$current_user = wp_get_current_user();

function my_login_page( $login_url ) {
    $user = $current_user;
    $valid_roles = [ "administrator", "editor", "custom-role" ];
    $the_roles = array_intersect( $valid_roles, $user->roles );

    if ( empty( $the_roles ) ) {
        return ( "/access-denied/" );
    } else {
        return ( "/login/" );
    }
}
add_filter( "login_url", "my_login_page", 10 );

Answer 1

It’s not too difficult:

$user = $current_user;
$valid_roles = [ 'administrator', 'editor', 'custom-role' ];
$the_roles = array_intersect( $valid_roles, $user->roles );

if ( empty( $the_roles ) ) {
    nocache_headers();
    wp_safe_redirect( '/access-denied/' ); 
    exit;
}