Home  >  Q&A  >  body text

When using the fetch object in PHP, the while loop cannot be used to take effect

<p>I am making a login page for the admin, but the while loop in the php code is not working. I'll leave the code here (sorry for the Spanish in the code) </p> <pre class="brush:php;toolbar:false;">//Create a connection $conn = mysqli_connect($servername, $username, $password, $dbname); // Check connection if (!$conn) { echo "An error occurred while connecting to the server."; } $username = $_POST["username"]; if ($username != "") { $password = $_POST["password"]; $accountLevel = $_POST["accountLevel"]; $content = $_POST["content"]; $sql = "SELECT password, accountLevel FROM `accounts1` WHERE username='".$username."'"; $result = mysqli_query($conn, $sql); while ($post = $result->fetch_object()) { if ($post->password != $password) { echo "Wrong password"; }else if ($post->accountLevel != $accountLevel) { echo "Error: Unable to publish. Account level error."; }else{ $sql = "INSERT INTO `blogposts`(`title`, `contentHTML`, `publishDate`, `commentSection`, `likes`, `dislikes`, `publisher`, `selector`) VALUES ('','". $_POST['content']."','".$_POST['publishDate']."','',0,0,'".$_POST['username']."','')" ; /*$fetchObj = mysqli_fetch_object($QueryResult); var_dump($fetchObj);*/ echo "sent"; } } }else{ echo "No user specified"; }</pre> <ul> <li><p>Is there a way to replace the while loop with a simpler assignment (since it is a login page and only checks one account)</p> </li> <li><p>Why does the while loop not work? I've used the same code before on another page and it worked perfectly fine and I didn't see any logic errors. </p> </li> </ul> <p>This is a request sent from a script with a function and I'm using request to a Php page. After that it reads the echo and displays it on the screen. (Just in case anyone needs this information)</p>
P粉803444331P粉803444331403 days ago465

reply all(1)I'll reply

  • P粉200138510

    P粉2001385102023-08-17 10:39:22

    Instead of using a while loop, just capture fetch_object() once and use if to test whether you get a true result.

    You should also use prepared statements, I show how to do that below.

    You should not store clear text passwords and should use password_hash() and password_verify(). I don't show that code below (it will require corresponding changes to your registration script).

    $username = $_POST["username"];
    if ($username != "") {
        $password = $_POST["password"];
        $accountLevel = $_POST["accountLevel"];
        $content = $_POST["content"];
        $sql = "SELECT password, accountLevel FROM `accounts1` WHERE username=?";
        $stmt = $conn->prepare($sql);
        $stmt->bind_param("s", $username);
        $stmt->execute();
        $result = $stmt->get_result();
        $post = $result->fetch_object();
        if ($post) {
            if ($post->password != $password) {
                echo "Usuario o Contraseña incorrecta";
            }else if ($post->accountLevel != $accountLevel) {
                echo "Error: No se pudo Publicar. Error de nivel de cuenta.";
            }else{
                $sql = "INSERT INTO `blogposts`(`title`, `contentHTML`, `publishDate`, `commentSection`, `likes`, `dislikes`, `publisher`, `selector`) VALUES ('',?,?,'',0,0,?,'')";
                $stmt = $conn->prepare($sql);
                $stmt->bind_param("sss", $content, $_POST['publishDate'], $username);
                $stmt->execute();
                echo "Enviado";
            }
        } else {
            echo "Usuario o Contraseña incorrecta";
        }
    }else{
        echo "Usuario no indicado";
    }

    reply
    0
  • Cancelreply