search
HomeBackend DevelopmentPHP TutorialMybb1.8 database core operation update_query has low-level bugs causing data loss

In the process of upgrading Mybb1.6 to 1.8, we encountered numerous problems. Recently, we discovered a serious bug in the code of the core operation update_query of the Mybb1.8 database, which caused the leading zeros to be missed when the data was saved. After a few hours, I found that the fault was not with me, but with mybb's upgrade code.  

Data table: test 
field 
ID  int(10) AUTO_INCREMENT 
name varchar (60) not null 
category varchar(5) 

In this table, category represents the classification, and the classification is represented by common codes, a total of five The first two digits, 0l to 99, represent major categories, and the last three digits represent small categories. Update the text through Ajax in the update statement, and update the data through update_query in the background statement. The program worked normally at level 1.6, but the update was chaotic at level 1.8. After checking, I found that the "0" in front of the category field was missing. The problem cannot be solved by changing various means. Finally, I dug out the data operation core file of Mybb and compared it with version 1.6 and found that there was a low-level bug in the code, causing the error. 

下面是1.8版数据更新过程 

Php代码  

function update_query($table, $array, $where="", $limit="", $no_quote=false)  
{  
    global $mybb;  
  
    if(!is_array($array))  
    {  
        return false;  
    }  
  
    $comma = "";  
    $query = "";  
    $quote = "'";  
  
    if($no_quote == true)  
    {  
        $quote = "";  
    }  
  
    foreach($array as $field => $value)  
    {  
        if(isset($mybb->binary_fields[$table][$field]) && $mybb->binary_fields[$table][$field])  
        {  
            if($value[0] != 'X') // Not escaped?  
            {  
                $value = $this->escape_binary($value);  
            }  
              
            $query .= $comma."`".$field."`={$value}";  
        }  
        else  
        {  
            if(is_numeric($value))  
            {  
                $query .= $comma."`".$field."`={$value}";  
            }  
            else  
            {  
                $query .= $comma."`".$field."`={$quote}{$value}{$quote}";  
            }  
        }  
        $comma = ', ';  
    }  
  
    if(!emptyempty($where))  
    {  
        $query .= " WHERE $where";  
    }  
  
    if(!emptyempty($limit))  
    {  
        $query .= " LIMIT $limit";  
    }  
  
    return $this->write_query("  
        UPDATE {$this->table_prefix}$table  
        SET $query  
    ");  
}



而1.6版本是这样的 

Php代码  

function update_query($table, $array, $where="", $limit="", $no_quote=false)  
    {  
        if(!is_array($array))  
        {  
            return false;  
        }  
          
        $comma = "";  
        $query = "";  
        $quote = "'";  
          
        if($no_quote == true)  
        {  
            $quote = "";  
        }  
          
        foreach($array as $field => $value)  
        {  
            $query .= $comma."`".$field."`={$quote}{$value}{$quote}";  
            $comma = ', ';  
        }  
          
        if(!emptyempty($where))  
        {  
            $query .= " WHERE $where";  
        }  
          
        if(!emptyempty($limit))  
        {  
            $query .= " LIMIT $limit";  
        }  
  
        return $this->write_query("  
            UPDATE {$this->table_prefix}$table  
            SET $query  
        ");  
    }



发生错误的是这样几句 

Php代码  

if(is_numeric($value))  
            {  
                $query .= $comma."`".$field."`={$value}";  
            }  
            else  
            {  
                $query .= $comma."`".$field."`={$quote}{$value}{$quote}";  
            }


传过来category的值可能是01002或08003,只要is_numeric($value)为真就是数字类型?!这是什么逻辑。其时mysql能自动处理识别字符型和数字型的差别,升级的1.8版把简单的事情复杂化,错误的逻辑导致bug发生,导致传过来的由数字组成的字符串存入数据库时前面的0丢失。如果前面不为0,就不会出错,这样导致数据一片混乱。 

一直以来很欣赏Mybb简洁的代码和漂亮的系统架构,2M代码包括图片CSS等竟然能完成如此多的功能,给予用户良好的扩展能力。没想到翻出这样一个bug,见笑了。1.6至1.8改动很大,发布过于仓促。总体说来,Mybb不失一个漂亮简洁的php论坛。


Statement
The content of this article is voluntarily contributed by netizens, and the copyright belongs to the original author. This site does not assume corresponding legal responsibility. If you find any content suspected of plagiarism or infringement, please contact admin@php.cn
Working with Flash Session Data in LaravelWorking with Flash Session Data in LaravelMar 12, 2025 pm 05:08 PM

Laravel simplifies handling temporary session data using its intuitive flash methods. This is perfect for displaying brief messages, alerts, or notifications within your application. Data persists only for the subsequent request by default: $request-

cURL in PHP: How to Use the PHP cURL Extension in REST APIscURL in PHP: How to Use the PHP cURL Extension in REST APIsMar 14, 2025 am 11:42 AM

The PHP Client URL (cURL) extension is a powerful tool for developers, enabling seamless interaction with remote servers and REST APIs. By leveraging libcurl, a well-respected multi-protocol file transfer library, PHP cURL facilitates efficient execution of various network protocols, including HTTP, HTTPS, and FTP. This extension offers granular control over HTTP requests, supports multiple concurrent operations, and provides built-in security features.

Simplified HTTP Response Mocking in Laravel TestsSimplified HTTP Response Mocking in Laravel TestsMar 12, 2025 pm 05:09 PM

Laravel provides concise HTTP response simulation syntax, simplifying HTTP interaction testing. This approach significantly reduces code redundancy while making your test simulation more intuitive. The basic implementation provides a variety of response type shortcuts: use Illuminate\Support\Facades\Http; Http::fake([ 'google.com' => 'Hello World', 'github.com' => ['foo' => 'bar'], 'forge.laravel.com' =>

12 Best PHP Chat Scripts on CodeCanyon12 Best PHP Chat Scripts on CodeCanyonMar 13, 2025 pm 12:08 PM

Do you want to provide real-time, instant solutions to your customers' most pressing problems? Live chat lets you have real-time conversations with customers and resolve their problems instantly. It allows you to provide faster service to your custom

Explain the concept of late static binding in PHP.Explain the concept of late static binding in PHP.Mar 21, 2025 pm 01:33 PM

Article discusses late static binding (LSB) in PHP, introduced in PHP 5.3, allowing runtime resolution of static method calls for more flexible inheritance.Main issue: LSB vs. traditional polymorphism; LSB's practical applications and potential perfo

PHP Logging: Best Practices for PHP Log AnalysisPHP Logging: Best Practices for PHP Log AnalysisMar 10, 2025 pm 02:32 PM

PHP logging is essential for monitoring and debugging web applications, as well as capturing critical events, errors, and runtime behavior. It provides valuable insights into system performance, helps identify issues, and supports faster troubleshoot

Discover File Downloads in Laravel with Storage::downloadDiscover File Downloads in Laravel with Storage::downloadMar 06, 2025 am 02:22 AM

The Storage::download method of the Laravel framework provides a concise API for safely handling file downloads while managing abstractions of file storage. Here is an example of using Storage::download() in the example controller:

HTTP Method Verification in LaravelHTTP Method Verification in LaravelMar 05, 2025 pm 04:14 PM

Laravel simplifies HTTP verb handling in incoming requests, streamlining diverse operation management within your applications. The method() and isMethod() methods efficiently identify and validate request types. This feature is crucial for building

See all articles

Hot AI Tools

Undresser.AI Undress

Undresser.AI Undress

AI-powered app for creating realistic nude photos

AI Clothes Remover

AI Clothes Remover

Online AI tool for removing clothes from photos.

Undress AI Tool

Undress AI Tool

Undress images for free

Clothoff.io

Clothoff.io

AI clothes remover

AI Hentai Generator

AI Hentai Generator

Generate AI Hentai for free.

Hot Article

Hot Tools

Dreamweaver Mac version

Dreamweaver Mac version

Visual web development tools

SAP NetWeaver Server Adapter for Eclipse

SAP NetWeaver Server Adapter for Eclipse

Integrate Eclipse with SAP NetWeaver application server.

Atom editor mac version download

Atom editor mac version download

The most popular open source editor

VSCode Windows 64-bit Download

VSCode Windows 64-bit Download

A free and powerful IDE editor launched by Microsoft

SublimeText3 Chinese version

SublimeText3 Chinese version

Chinese version, very easy to use